media: ov8856: suppress probe deferral errors

Probe deferral should not be logged as an error:

	ov8856 24-0010: failed to get HW configuration: -517

Use dev_err_probe() for the clock lookup and drop the (mostly) redundant
dev_err() from sensor probe() to suppress it.

Note that errors during regulator lookup is already correctly logged
using dev_err_probe().

Fixes: 0c2c7a1e0d69 ("media: ov8856: Add devicetree support")
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
index e6704d01824815f7063bbeabc02afcd242f2751a..4b6874d2a104ad4858349e6dee67f5e34318c18b 100644 (file)
--- a/drivers/media/i2c/ov8856.c
+++ b/drivers/media/i2c/ov8856.c
@@ -2276,8 +2276,8 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, struct device *dev)
        if (!is_acpi_node(fwnode)) {
                ov8856->xvclk = devm_clk_get(dev, "xvclk");
                if (IS_ERR(ov8856->xvclk)) {
-                       dev_err(dev, "could not get xvclk clock (%pe)\n",
-                               ov8856->xvclk);
+                       dev_err_probe(dev, PTR_ERR(ov8856->xvclk),
+                                     "could not get xvclk clock\n");
                        return PTR_ERR(ov8856->xvclk);
                }
 
@@ -2382,11 +2382,8 @@ static int ov8856_probe(struct i2c_client *client)
                return -ENOMEM;
 
        ret = ov8856_get_hwcfg(ov8856, &client->dev);
-       if (ret) {
-               dev_err(&client->dev, "failed to get HW configuration: %d",
-                       ret);
+       if (ret)
                return ret;
-       }
 
        v4l2_i2c_subdev_init(&ov8856->sd, client, &ov8856_subdev_ops);