]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
smb: client: mask server-provided mode to 07777 in modefromsid
authorNorbert Manthey <nmanthey@amazon.de>
Thu, 9 Jul 2026 15:54:39 +0000 (15:54 +0000)
committerSteve French <stfrench@microsoft.com>
Thu, 9 Jul 2026 17:25:16 +0000 (12:25 -0500)
When modefromsid is active, parse_dacl() applies the server-provided
sub_auth[2] value from the NFS mode SID to cf_mode without masking to
07777. Apply the correct masking, same as in the read path.

Fixes: e2f8fbfb8d09c ("cifs: get mode bits from special sid on stat")
Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
Assisted-by: Kiro:claude-opus-4.6
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifsacl.c

index 07cf0e5782337d9d26801db4a8929927d749ea3b..9424281a7674cbd3239c16bfcc936d2057ae07ec 100644 (file)
@@ -962,7 +962,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl,
                                 */
                                fattr->cf_mode &= ~07777;
                                fattr->cf_mode |=
-                                       le32_to_cpu(ppace[i]->sid.sub_auth[2]);
+                                       le32_to_cpu(ppace[i]->sid.sub_auth[2]) & 07777;
                                break;
                        } else {
                                if (compare_sids(&(ppace[i]->sid), pownersid) == 0) {