]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: don't use token set/get accessors in inode.c:fill_inode_item()
authorDavid Sterba <dsterba@suse.com>
Fri, 27 Jun 2025 14:03:51 +0000 (16:03 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 21 Jul 2025 22:04:59 +0000 (00:04 +0200)
The token versions of set/get accessors will be removed, use the normal
helpers.

There's additional overhead of the token helpers that update the cached
address in case it moves to another page/folio. The normal versions
don't need to do that.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c

index 403b94553f8e0a93ec9fccbb33a809aef11b5338..d7a2ea7d121f06ecb55133a7e857b6848bdb2e9b 100644 (file)
@@ -4077,45 +4077,35 @@ static void fill_inode_item(struct btrfs_trans_handle *trans,
                            struct btrfs_inode_item *item,
                            struct inode *inode)
 {
-       struct btrfs_map_token token;
        u64 flags;
 
-       btrfs_init_map_token(&token, leaf);
-
-       btrfs_set_token_inode_uid(&token, item, i_uid_read(inode));
-       btrfs_set_token_inode_gid(&token, item, i_gid_read(inode));
-       btrfs_set_token_inode_size(&token, item, BTRFS_I(inode)->disk_i_size);
-       btrfs_set_token_inode_mode(&token, item, inode->i_mode);
-       btrfs_set_token_inode_nlink(&token, item, inode->i_nlink);
-
-       btrfs_set_token_timespec_sec(&token, &item->atime,
-                                    inode_get_atime_sec(inode));
-       btrfs_set_token_timespec_nsec(&token, &item->atime,
-                                     inode_get_atime_nsec(inode));
-
-       btrfs_set_token_timespec_sec(&token, &item->mtime,
-                                    inode_get_mtime_sec(inode));
-       btrfs_set_token_timespec_nsec(&token, &item->mtime,
-                                     inode_get_mtime_nsec(inode));
-
-       btrfs_set_token_timespec_sec(&token, &item->ctime,
-                                    inode_get_ctime_sec(inode));
-       btrfs_set_token_timespec_nsec(&token, &item->ctime,
-                                     inode_get_ctime_nsec(inode));
-
-       btrfs_set_token_timespec_sec(&token, &item->otime, BTRFS_I(inode)->i_otime_sec);
-       btrfs_set_token_timespec_nsec(&token, &item->otime, BTRFS_I(inode)->i_otime_nsec);
-
-       btrfs_set_token_inode_nbytes(&token, item, inode_get_bytes(inode));
-       btrfs_set_token_inode_generation(&token, item,
-                                        BTRFS_I(inode)->generation);
-       btrfs_set_token_inode_sequence(&token, item, inode_peek_iversion(inode));
-       btrfs_set_token_inode_transid(&token, item, trans->transid);
-       btrfs_set_token_inode_rdev(&token, item, inode->i_rdev);
+       btrfs_set_inode_uid(leaf, item, i_uid_read(inode));
+       btrfs_set_inode_gid(leaf, item, i_gid_read(inode));
+       btrfs_set_inode_size(leaf, item, BTRFS_I(inode)->disk_i_size);
+       btrfs_set_inode_mode(leaf, item, inode->i_mode);
+       btrfs_set_inode_nlink(leaf, item, inode->i_nlink);
+
+       btrfs_set_timespec_sec(leaf, &item->atime, inode_get_atime_sec(inode));
+       btrfs_set_timespec_nsec(leaf, &item->atime, inode_get_atime_nsec(inode));
+
+       btrfs_set_timespec_sec(leaf, &item->mtime, inode_get_mtime_sec(inode));
+       btrfs_set_timespec_nsec(leaf, &item->mtime, inode_get_mtime_nsec(inode));
+
+       btrfs_set_timespec_sec(leaf, &item->ctime, inode_get_ctime_sec(inode));
+       btrfs_set_timespec_nsec(leaf, &item->ctime, inode_get_ctime_nsec(inode));
+
+       btrfs_set_timespec_sec(leaf, &item->otime, BTRFS_I(inode)->i_otime_sec);
+       btrfs_set_timespec_nsec(leaf, &item->otime, BTRFS_I(inode)->i_otime_nsec);
+
+       btrfs_set_inode_nbytes(leaf, item, inode_get_bytes(inode));
+       btrfs_set_inode_generation(leaf, item, BTRFS_I(inode)->generation);
+       btrfs_set_inode_sequence(leaf, item, inode_peek_iversion(inode));
+       btrfs_set_inode_transid(leaf, item, trans->transid);
+       btrfs_set_inode_rdev(leaf, item, inode->i_rdev);
        flags = btrfs_inode_combine_flags(BTRFS_I(inode)->flags,
                                          BTRFS_I(inode)->ro_flags);
-       btrfs_set_token_inode_flags(&token, item, flags);
-       btrfs_set_token_inode_block_group(&token, item, 0);
+       btrfs_set_inode_flags(leaf, item, flags);
+       btrfs_set_inode_block_group(leaf, item, 0);
 }
 
 /*