Bug 445104: ssl redirects come with a 200 OK HTTP code on mod_perl

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat

diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index 4c62ab3ac78413b4041748bc02672cc3e3813efe..0de89408e4500f6daf7005dd568b85a8e352ca0b 100644 (file)
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -307,7 +307,11 @@ sub require_https {
         $url = $self->self_url;
         $url =~ s/^http:/https:/i;
     }
-    print $self->redirect(-location => $url, -status => $status). "\n";
+    print $self->redirect(-location => $url, -status => $status);
+    # When using XML-RPC with mod_perl, we need the headers sent immediately.
+    # We used to do this by appending a newline to $self->redirect, but
+    # that breaks normal web browser redirects.
+    $self->r->rflush if $ENV{MOD_PERL};
     exit;
 }