]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: tps6586x: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 2 Jul 2025 09:14:13 +0000 (11:14 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Jul 2025 07:45:30 +0000 (09:45 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250702-gpiochip-set-rv-gpio-round3-v1-12-0d23be74f71d@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-tps6586x.c

index d277aa951143ccf9560bd77d461786f120e46a52..f1ced092f38a5e491378fec2d80dcc1eb1182cbd 100644 (file)
@@ -40,13 +40,13 @@ static int tps6586x_gpio_get(struct gpio_chip *gc, unsigned offset)
        return !!(val & (1 << offset));
 }
 
-static void tps6586x_gpio_set(struct gpio_chip *gc, unsigned offset,
-                             int value)
+static int tps6586x_gpio_set(struct gpio_chip *gc, unsigned int offset,
+                            int value)
 {
        struct tps6586x_gpio *tps6586x_gpio = gpiochip_get_data(gc);
 
-       tps6586x_update(tps6586x_gpio->parent, TPS6586X_GPIOSET2,
-                       value << offset, 1 << offset);
+       return tps6586x_update(tps6586x_gpio->parent, TPS6586X_GPIOSET2,
+                              value << offset, 1 << offset);
 }
 
 static int tps6586x_gpio_output(struct gpio_chip *gc, unsigned offset,
@@ -54,8 +54,11 @@ static int tps6586x_gpio_output(struct gpio_chip *gc, unsigned offset,
 {
        struct tps6586x_gpio *tps6586x_gpio = gpiochip_get_data(gc);
        uint8_t val, mask;
+       int ret;
 
-       tps6586x_gpio_set(gc, offset, value);
+       ret = tps6586x_gpio_set(gc, offset, value);
+       if (ret)
+               return ret;
 
        val = 0x1 << (offset * 2);
        mask = 0x3 << (offset * 2);
@@ -95,7 +98,7 @@ static int tps6586x_gpio_probe(struct platform_device *pdev)
 
        /* FIXME: add handling of GPIOs as dedicated inputs */
        tps6586x_gpio->gpio_chip.direction_output = tps6586x_gpio_output;
-       tps6586x_gpio->gpio_chip.set    = tps6586x_gpio_set;
+       tps6586x_gpio->gpio_chip.set_rv = tps6586x_gpio_set;
        tps6586x_gpio->gpio_chip.get    = tps6586x_gpio_get;
        tps6586x_gpio->gpio_chip.to_irq = tps6586x_gpio_to_irq;