]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virNetDevVlanParse: Use g_autofree for temporary variables
authorPeter Krempa <pkrempa@redhat.com>
Mon, 20 Oct 2025 13:16:48 +0000 (15:16 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 21 Oct 2025 13:33:54 +0000 (15:33 +0200)
Automatically free the variables to prevent leaks when returning from
middle of the function.

Fixes: 1de6fd5edb5
Closes: https://gitlab.com/libvirt/libvirt/-/issues/824
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/netdev_vlan_conf.c

index b98c4d92cf3f6127bc76d086f2e7b6ebab3c4d05..012a28034e05271d35e81f8dbfa453e4e919963f 100644 (file)
@@ -34,8 +34,8 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def)
 {
     int ret = -1;
     VIR_XPATH_NODE_AUTORESTORE(ctxt)
-    char *trunk = NULL;
-    xmlNodePtr *tagNodes = NULL;
+    g_autofree char *trunk = NULL;
+    g_autofree xmlNodePtr *tagNodes = NULL;
     int nTags;
     size_t i;
 
@@ -120,8 +120,6 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def)
 
     ret = 0;
  cleanup:
-    VIR_FREE(tagNodes);
-    VIR_FREE(trunk);
     return ret;
 }