]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: cmipci: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:06:36 +0000 (12:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:18 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-55-tiwai@suse.de
sound/pci/cmipci.c

index b00df0a60d3f4ba13192b740a7f7a4782cae209f..9056214e9cdae54b5995f8655a9d13bf101372dc 100644 (file)
@@ -1868,7 +1868,7 @@ static int snd_cmipci_pcm_new(struct cmipci *cm, int device)
 
        pcm->private_data = cm;
        pcm->info_flags = 0;
-       strcpy(pcm->name, "C-Media PCI DAC/ADC");
+       strscpy(pcm->name, "C-Media PCI DAC/ADC");
        cm->pcm = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
@@ -1890,7 +1890,7 @@ static int snd_cmipci_pcm2_new(struct cmipci *cm, int device)
 
        pcm->private_data = cm;
        pcm->info_flags = 0;
-       strcpy(pcm->name, "C-Media PCI 2nd DAC");
+       strscpy(pcm->name, "C-Media PCI 2nd DAC");
        cm->pcm2 = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
@@ -1913,7 +1913,7 @@ static int snd_cmipci_pcm_spdif_new(struct cmipci *cm, int device)
 
        pcm->private_data = cm;
        pcm->info_flags = 0;
-       strcpy(pcm->name, "C-Media PCI IEC958");
+       strscpy(pcm->name, "C-Media PCI IEC958");
        cm->pcm_spdif = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
@@ -2633,7 +2633,7 @@ static int snd_cmipci_mixer_new(struct cmipci *cm, int pcm_spdif_device)
 
        card = cm->card;
 
-       strcpy(card->mixername, "CMedia PCI");
+       strscpy(card->mixername, "CMedia PCI");
 
        spin_lock_irq(&cm->reg_lock);
        snd_cmipci_mixer_write(cm, 0x00, 0x00);         /* mixer reset */
@@ -3216,14 +3216,14 @@ static int snd_cmipci_probe(struct pci_dev *pci,
        switch (pci->device) {
        case PCI_DEVICE_ID_CMEDIA_CM8738:
        case PCI_DEVICE_ID_CMEDIA_CM8738B:
-               strcpy(card->driver, "CMI8738");
+               strscpy(card->driver, "CMI8738");
                break;
        case PCI_DEVICE_ID_CMEDIA_CM8338A:
        case PCI_DEVICE_ID_CMEDIA_CM8338B:
-               strcpy(card->driver, "CMI8338");
+               strscpy(card->driver, "CMI8338");
                break;
        default:
-               strcpy(card->driver, "CMIPCI");
+               strscpy(card->driver, "CMIPCI");
                break;
        }