]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
ch: check return value of virJSONValueArrayAppend
authorJán Tomko <jtomko@redhat.com>
Wed, 6 Nov 2024 13:03:27 +0000 (14:03 +0100)
committerJán Tomko <jtomko@redhat.com>
Wed, 6 Nov 2024 16:12:32 +0000 (17:12 +0100)
It only errors out when presented with a non-array, but we do check
it everywhere else.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/ch/ch_monitor.c

index 3e49902791e2f1ce94e9aa81e5f28213d9d4781d..ccd04cfbd19cf1dc4d63baa91cfa68eb877e5019 100644 (file)
@@ -1002,7 +1002,8 @@ virCHMonitorBuildRestoreJson(virDomainDef *vmdef,
                 return -1;
             if (virJSONValueObjectAppendNumberInt(net_json, "num_fds", vmdef->nets[i]->driver.virtio.queues))
                 return -1;
-            virJSONValueArrayAppend(nets, &net_json);
+            if (virJSONValueArrayAppend(nets, &net_json) < 0)
+                return -1;
         }
         if (virJSONValueObjectAppend(restore_json, "net_fds", &nets))
             return -1;