]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
iterate: use resolve_badmsg() fallback for more RCODEs
authorVladimír Čunát <vladimir.cunat@nic.cz>
Wed, 22 Apr 2020 11:38:39 +0000 (13:38 +0200)
committerPetr Špaček <petr.spacek@nic.cz>
Thu, 23 Apr 2020 10:11:48 +0000 (12:11 +0200)
+ REFUSED and SERVFAIL (in non-STUB)

lib/layer/iterate.c

index 55f79abb05c8aa5d4eafb02d1ef1fbc2ffb44bb4..6558c50b7de02431ad0e6a7825ba35f153942500 100644 (file)
@@ -1069,14 +1069,12 @@ static int resolve(kr_layer_t *ctx, knot_pkt_t *pkt)
        case KNOT_RCODE_NXDOMAIN:
                break; /* OK */
        case KNOT_RCODE_REFUSED:
-       case KNOT_RCODE_SERVFAIL: {
+       case KNOT_RCODE_SERVFAIL:
                if (query->flags.STUB) {
-                        /* Pass through in stub mode */
+                        /* just pass answer through if in stub mode */
                        break;
                }
-               VERBOSE_MSG("<= rcode: %s\n", rcode ? rcode->name : "??");
-               return KR_STATE_FAIL;
-       }
+               /* fall through */
        case KNOT_RCODE_FORMERR:
                VERBOSE_MSG("<= rcode: %s\n", rcode ? rcode->name : "??");
                return resolve_badmsg(pkt, req, query);