]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amd/powerplay: Fix CIK shutdown temperature
authorTimur Kristóf <timur.kristof@gmail.com>
Mon, 13 Oct 2025 06:06:42 +0000 (08:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Oct 2025 14:20:35 +0000 (16:20 +0200)
[ Upstream commit 6917112af2ba36c5f19075eb9f2933ffd07e55bf ]

Remove extra multiplication.

CIK GPUs such as Hawaii appear to use PP_TABLE_V0 in which case
the shutdown temperature is hardcoded in smu7_init_dpm_defaults
and is already multiplied by 1000. The value was mistakenly
multiplied another time by smu7_get_thermal_temperature_range.

Fixes: 4ba082572a42 ("drm/amd/powerplay: export the thermal ranges of VI asics (V2)")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1676
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c

index 632a25957477ee45151f7b51977af387d7719439..3018e294673a5ba725538e25938be9cb3e84c074 100644 (file)
@@ -5444,8 +5444,7 @@ static int smu7_get_thermal_temperature_range(struct pp_hwmgr *hwmgr,
                thermal_data->max = table_info->cac_dtp_table->usSoftwareShutdownTemp *
                        PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
        else if (hwmgr->pp_table_version == PP_TABLE_V0)
-               thermal_data->max = data->thermal_temp_setting.temperature_shutdown *
-                       PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
+               thermal_data->max = data->thermal_temp_setting.temperature_shutdown;
 
        thermal_data->sw_ctf_threshold = thermal_data->max;