]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: rockchip: move reset to dedicated eth-phy node on ringneck
authorHeiko Stuebner <heiko.stuebner@cherry.de>
Wed, 14 May 2025 15:07:41 +0000 (17:07 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 15 May 2025 12:47:54 +0000 (14:47 +0200)
Using snps,reset-* properties to handle the ethernet-phy resets is
deprecated and instead a real phy node should be used.

Move the Ringneck phy-reset properties to such a node

Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Tested-by: Quentin Schulz <quentin.schulz@cherry.de>
Link: https://lore.kernel.org/r/20250514150745.2437804-3-heiko@sntech.de
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi

index 142244d5270608050c3da0e58db167f16b40174b..ab232e5c7ad614b49729f893dd4a84da9ff8ff38 100644 (file)
@@ -83,9 +83,7 @@
 
 /* On-module TI DP83825I PHY but no connector, enable in carrierboard */
 &gmac {
-       snps,reset-gpio = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
-       snps,reset-active-low;
-       snps,reset-delays-us = <0 50000 50000>;
+       phy-handle = <&dp83825>;
        phy-supply = <&vcc_3v3>;
        clock_in_out = "output";
 };
        status = "okay";
 };
 
+&mdio {
+       dp83825: ethernet-phy@0 {
+               compatible = "ethernet-phy-ieee802.3-c22";
+               reg = <0x0>;
+               pinctrl-names = "default";
+               pinctrl-0 = <&phy_rst>;
+               reset-assert-us = <50000>;
+               reset-deassert-us = <50000>;
+               reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
+       };
+};
+
 &pinctrl {
        emmc {
                emmc_reset: emmc-reset {
                };
        };
 
+       ethernet {
+               phy_rst: phy-rst {
+                       rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+               };
+       };
+
        leds {
                module_led_pin: module-led-pin {
                        rockchip,pins = <1 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;