dnsdist: Handle exception raised in IOStateGuard's destructor

Reported by Coverity (CID 372512).

diff --git a/pdns/dnsdistdist/tcpiohandler-mplexer.hh b/pdns/dnsdistdist/tcpiohandler-mplexer.hh
index 2fbe4b5147e4c48f32d3142904a2e92ef4d89119..d62ba7828b81ad0036b96d3014bbfe89cd7f78a1 100644 (file)
--- a/pdns/dnsdistdist/tcpiohandler-mplexer.hh
+++ b/pdns/dnsdistdist/tcpiohandler-mplexer.hh
@@ -187,7 +187,13 @@ public:
        and its reference count goes to zero */
     if (d_enabled && d_handler) {
       DEBUGLOG("IOStateGuard destroyed while holding a state, let's reset it");
-      d_handler->reset();
+      try {
+        d_handler->reset();
+      }
+      catch (const FDMultiplexerException& e) {
+        /* that should not happen, but an exception raised from a destructor would be bad so better
+           safe than sorry */
+      }
       d_enabled = false;
     }
   }