tests/gunit: Extend the fuzzer to test cgroup_set_value_uint64()

Add fuzzing to the cgroup_set_value_uint64() API, by passing combination
of valid/NULL as arguments to the API.

[----------] 10 tests from APIArgsTest
[ RUN      ] APIArgsTest.API_cgroup_set_permissions
[       OK ] APIArgsTest.API_cgroup_set_permissions (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_new_cgroup
[       OK ] APIArgsTest.API_cgroup_new_cgroup (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_set_value_string
[       OK ] APIArgsTest.API_cgroup_set_value_string (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_get_value_string
[       OK ] APIArgsTest.API_cgroup_get_value_string (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_add_controller
[       OK ] APIArgsTest.API_cgroup_add_controller (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_add_value_string
[       OK ] APIArgsTest.API_cgroup_add_value_string (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_get_uid_gid
[       OK ] APIArgsTest.API_cgroup_get_uid_gid (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_set_value_int64
[       OK ] APIArgsTest.API_cgroup_set_value_int64 (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_get_value_int64
[       OK ] APIArgsTest.API_cgroup_get_value_int64 (0 ms)
[ RUN      ] APIArgsTest.API_cgroup_set_value_uint64
[       OK ] APIArgsTest.API_cgroup_set_value_uint64 (0 ms)
[----------] 10 tests from APIArgsTest (0 ms total)

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
(cherry picked from commit 4467ccbd0bf54aa4ad8c7c50628ce2a46668181f)

diff --git a/tests/gunit/017-API_fuzz_test.cpp b/tests/gunit/017-API_fuzz_test.cpp
index 3f8a147a699fd941d747726b5b39a860b0280ebd..d6ceb00f4cf49ebc1a7f33d63dde5f25f185f8c1 100644 (file)
--- a/tests/gunit/017-API_fuzz_test.cpp
+++ b/tests/gunit/017-API_fuzz_test.cpp
@@ -426,3 +426,58 @@ TEST_F(APIArgsTest, API_cgroup_get_value_int64)
        ret = cgroup_get_value_int64(cgc, name, &value);
        ASSERT_EQ(ret, 50011);
 }
+
+/**
+ * Test arguments passed to set a controller's setting
+ * @param APIArgsTest googletest test case name
+ * @param API_cgroup_set_value_uint64 test name
+ *
+ * This test will pass a combination of valid and NULL as
+ * arguments to cgroup_set_value_uint64() and check if it
+ * handles it gracefully.
+ */
+TEST_F(APIArgsTest, API_cgroup_set_value_uint64)
+{
+       const char * const cg_name = "FuzzerCgroup";
+       struct cgroup_controller * cgc = NULL;
+       const char * const cg_ctrl = "cpu";
+       struct cgroup *cgroup = NULL;
+       u_int64_t value = 1024;
+       char * name = NULL;
+       int ret;
+
+       // case 1
+       // cgc = NULL, name = NULL, value = valid
+       ret = cgroup_set_value_uint64(cgc, name, value);
+       ASSERT_EQ(ret, 50011);
+
+       // case 2
+       // cgc = valid, name = NULL, value = valid
+       cgroup = cgroup_new_cgroup(cg_name);
+       ASSERT_NE(cgroup, nullptr);
+
+       cgc = cgroup_add_controller(cgroup, cg_ctrl);
+       ASSERT_NE(cgroup, nullptr);
+
+       // set cpu.shares, so that cgc->index > 0
+       ret = cgroup_set_value_uint64(cgc, "cpu.shares", 1024);
+       ASSERT_EQ(ret, 0);
+
+       ret = cgroup_set_value_uint64(cgc, name, value);
+       ASSERT_EQ(ret, 50011);
+
+       // case 3
+       // cgc = valid, name = valid, value = valid
+       name = strdup("cpu.shares");
+       ASSERT_NE(name, nullptr);
+
+       ret = cgroup_set_value_uint64(cgc, name, value);
+       ASSERT_EQ(ret, 0);
+
+       // check if the value was set right
+       ret = cgroup_get_value_uint64(cgc, name, &value);
+       ASSERT_EQ(ret, 0);
+       ASSERT_EQ(value, 1024);
+
+       free(name);
+}