]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: target: Do not write NUL characters into ASCII configfs output
authorBart Van Assche <bvanassche@acm.org>
Mon, 27 Oct 2025 18:46:38 +0000 (11:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:02:48 +0000 (14:02 +0100)
[ Upstream commit c03b55f235e283cae49c88b9602fd11096b92eba ]

NUL characters are not allowed in ASCII configfs output. Hence this
patch.

Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20251027184639.3501254-2-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/target/target_core_configfs.c

index b19acd662726d4377036bc80a3e969748947a2e1..1bd28482e7cb3e930c1c9ce080b790fd6f33ce43 100644 (file)
@@ -2772,7 +2772,6 @@ static ssize_t target_lu_gp_members_show(struct config_item *item, char *page)
                cur_len = snprintf(buf, LU_GROUP_NAME_BUF, "%s/%s\n",
                        config_item_name(&hba->hba_group.cg_item),
                        config_item_name(&dev->dev_group.cg_item));
-               cur_len++; /* Extra byte for NULL terminator */
 
                if ((cur_len + len) > PAGE_SIZE || cur_len > LU_GROUP_NAME_BUF) {
                        pr_warn("Ran out of lu_gp_show_attr"