BUG/MEDIUM: tools: fix bad character handling in str2sa_range()

Commit d4448bc8 brought support for parsing port ranges, but invalid
characters are not properly handled and can result in a crash while
parsing the configuration if an invalid character is present in the
port, because the return value is set to NULL then dereferenced.

diff --git a/src/standard.c b/src/standard.c
index db0e0e409085f5e450cf07c68f18ceac21274769..be6b91190ff5932d697eff2a572f0fc6600b9664 100644 (file)
--- a/src/standard.c
+++ b/src/standard.c
@@ -679,8 +679,10 @@ struct sockaddr_storage *str2sa_range(const char *str, int *low, int *high)
                porth = atoi(port1 + 1);
                porta = porth;
        }
-       else if (*port1) /* other any unexpected char */
+       else if (*port1) { /* other any unexpected char */
                ret = NULL;
+               goto out;
+       }
 
        set_host_port(ret, porta);