'event' must be non NULL, remove test.

1401        }

	CID 1453455 (#1 of 1): Dereference before null check (REVERSE_INULL)
	check_after_deref: Null-checking event suggests that it may be null,
	but it has already been dereferenced on all paths leading to the check.

1402        if (event != NULL)
1403                isc_event_free(ISC_EVENT_PTR(&event));

diff --git a/lib/dns/client.c b/lib/dns/client.c
index 757fb42136d87d7b2e374889fd6814914a84cab6..ad4342be6a9bbd45e2ef27d0fed681e13b45c1cb 100644 (file)
--- a/lib/dns/client.c
+++ b/lib/dns/client.c
@@ -1393,8 +1393,7 @@ dns_client_startresolve(dns_client_t *client, const dns_name_t *name,
                isc_mutex_destroy(&rctx->lock);
                isc_mem_put(mctx, rctx, sizeof(*rctx));
        }
-       if (event != NULL)
-               isc_event_free(ISC_EVENT_PTR(&event));
+       isc_event_free(ISC_EVENT_PTR(&event));
        isc_task_detach(&tclone);
        dns_view_detach(&view);