Merged revisions 281390 via svnmerge from

https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r281390 | jpeeler | 2010-08-09 15:04:30 -0500 (Mon, 09 Aug 2010) | 13 lines

  Prevent loss of Caller ID information set on local channel after masquerade.

  Caller ID set on the channel before a masquerade occurs when using a local
  channel would cause the information to be lost. The problem was that the
  information was set on a channel destined to be hung up. The somewhat confusing
  fix is to detect if any Caller ID has been set on the channel and if so
  preswap the Caller ID data so that basically the masquerade puts the data back.

  (closes issue #17138)
  Reported by: kobaz

  Review: https://reviewboard.asterisk.org/r/847/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@281391 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_local.c b/channels/chan_local.c
index a26b8f718750c9aee6d67f264e3725450e31b0ba..46451776f87f1d6e1c711ba98ad9cca132396810 100644 (file)
--- a/channels/chan_local.c
+++ b/channels/chan_local.c
@@ -384,6 +384,26 @@ static void check_bridge(struct local_pvt *p)
                                                        p->chan->audiohooks = p->owner->audiohooks;
                                                        p->owner->audiohooks = audiohooks_swapper;
                                                }
+
+                                               /* If any Caller ID was set, preserve it after masquerade like above. We must check
+                                                * to see if Caller ID was set because otherwise we'll mistakingly copy info not
+                                                * set from the dialplan and will overwrite the real channel Caller ID. The reason
+                                                * for this whole preswapping action is because the Caller ID is set on the channel
+                                                * thread (which is the to be masqueraded away local channel) before both local
+                                                * channels are optimized away.
+                                                */
+                                               if (p->owner->cid.cid_dnid || p->owner->cid.cid_num ||
+                                                       p->owner->cid.cid_name || p->owner->cid.cid_ani ||
+                                                       p->owner->cid.cid_rdnis || p->owner->cid.cid_pres ||  
+                                                       p->owner->cid.cid_ani2 || p->owner->cid.cid_ton ||  
+                                                       p->owner->cid.cid_tns) {
+
+                                                       struct ast_callerid tmpcid;
+                                                       tmpcid = p->owner->cid;
+                                                       p->owner->cid = p->chan->_bridge->cid;
+                                                       p->chan->_bridge->cid = tmpcid;
+                                               }
+
                                                ast_app_group_update(p->chan, p->owner);
                                                ast_channel_masquerade(p->owner, p->chan->_bridge);
                                                ast_set_flag(p, LOCAL_ALREADY_MASQED);