]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
test: let qemuhotplugtest report details of init fails
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>
Thu, 16 Jan 2020 08:13:28 +0000 (09:13 +0100)
committerChristian Ehrhardt <christian.ehrhardt@canonical.com>
Wed, 22 Jan 2020 08:51:52 +0000 (10:51 +0200)
If virHostdevManagerGetDefault in qemuhotplugtest fails it works
for quite a while to later segfault when accessing
mgr->activePCIHostdevs.

Report the error details and break on a failed init to see the
real issue right away.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
tests/qemuhotplugtest.c

index a60c8d1c9389b5f731c5871525b0f6ba719f3819..6a3e61c54bdd7ca096e24ff13e9fb83e6f15134f 100644 (file)
@@ -634,6 +634,11 @@ mymain(void)
         return EXIT_FAILURE;
 
     driver.hostdevMgr = virHostdevManagerGetDefault();
+    if (driver.hostdevMgr == NULL) {
+        VIR_TEST_VERBOSE("Could not initialize HostdevManager - %s\n",
+                         virGetLastErrorMessage());
+        return EXIT_FAILURE;
+    }
 
 
 #define DO_TEST(file, ACTION, dev, fial, kep, ...) \