]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Mark `classmethod` PaddingOption.from_wire
authorJosh Soref <2119212+jsoref@users.noreply.github.com>
Mon, 17 Nov 2025 13:29:15 +0000 (08:29 -0500)
committerPieter Lexis <pieter.lexis@powerdns.com>
Mon, 15 Jun 2026 08:44:25 +0000 (10:44 +0200)
Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>
regression-tests.common/paddingoption.py

index bb3382e1a129442a1abb5e4bc13e17d1aacf8de6..a6983151ecafca537c7b54fe039c47224959c5c4 100644 (file)
@@ -22,6 +22,7 @@ class PaddingOption(dns.edns.Option):
         file.write(bytes(self.numberOfBytes))
         return None
 
+    @classmethod
     def from_wire(cls, otype, wire, current, olen):
         """Read EDNS packet as defined in rfc7830.
 
@@ -33,8 +34,6 @@ class PaddingOption(dns.edns.Option):
 
         return cls(numberOfBytes)
 
-    from_wire = classmethod(from_wire)
-
     # needed in 2.0.0
     @classmethod
     def from_wire_parser(cls, otype, parser):
@@ -50,7 +49,7 @@ class PaddingOption(dns.edns.Option):
     def __eq__(self, other):
         if not isinstance(other, PaddingOption):
             return False
-        return self.numberOfBytes == numberOfBytes
+        return self.numberOfBytes == other.numberOfBytes
 
     def __ne__(self, other):
         return not self.__eq__(other)