]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
tracing: Check the return value of tracing_update_buffers()
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 7 Jan 2026 21:15:10 +0000 (16:15 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 26 Jan 2026 22:44:40 +0000 (17:44 -0500)
In the very unlikely event that tracing_update_buffers() fails in
trace_printk_init_buffers(), report the failure so that it is known.

Link: https://lore.kernel.org/all/20220917020353.3836285-1-floridsleeves@gmail.com/
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20260107161510.4dc98b15@gandalf.local.home
Suggested-by: Li Zhong <floridsleeves@gmail.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace.c

index 8bd4ec08fb361a3b349d0114b4ed0e0fef2b4ee1..870205cba31ef7ae8b9895e24339cb4f51e8e5ce 100644 (file)
@@ -3309,9 +3309,10 @@ void trace_printk_init_buffers(void)
        pr_warn("**********************************************************\n");
 
        /* Expand the buffers to set size */
-       tracing_update_buffers(&global_trace);
-
-       buffers_allocated = 1;
+       if (tracing_update_buffers(&global_trace) < 0)
+               pr_err("Failed to expand tracing buffers for trace_printk() calls\n");
+       else
+               buffers_allocated = 1;
 
        /*
         * trace_printk_init_buffers() can be called by modules.