]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pldmfw: Don't require send_package_data or send_component_table to be defined
authorLee Trager <lee@trager.us>
Mon, 12 May 2025 18:53:57 +0000 (11:53 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 15 May 2025 10:59:18 +0000 (12:59 +0200)
Not all drivers require send_package_data or send_component_table when
updating firmware. Instead of forcing drivers to implement a stub allow
these functions to go undefined.

Signed-off-by: Lee Trager <lee@trager.us>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250512190109.2475614-2-lee@trager.us
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
lib/pldmfw/pldmfw.c

index 6264e2013f25ee1f9f729b5689c5542e8e4c2b78..b45ceb7257801aea6b7b665316fbe1b1248b97b1 100644 (file)
@@ -728,6 +728,9 @@ pldm_send_package_data(struct pldmfw_priv *data)
        struct pldmfw_record *record = data->matching_record;
        const struct pldmfw_ops *ops = data->context->ops;
 
+       if (!ops->send_package_data)
+               return 0;
+
        return ops->send_package_data(data->context, record->package_data,
                                      record->package_data_len);
 }
@@ -755,6 +758,9 @@ pldm_send_component_tables(struct pldmfw_priv *data)
                if (!test_bit(index, bitmap))
                        continue;
 
+               if (!data->context->ops->send_component_table)
+                       continue;
+
                /* determine whether this is the start, middle, end, or both
                 * the start and end of the component tables
                 */