]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts
authorNiklas Cassel <cassel@kernel.org>
Mon, 10 Mar 2025 11:10:22 +0000 (12:10 +0100)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 26 Mar 2025 06:11:49 +0000 (06:11 +0000)
Neither RK3568 or RK3588 supports INTx interrupts.

Since epc_features is zero initialized, this is strictly not needed.
However, setting intx_capable explicitly to false makes it more clear
that neither RK3568 or RK3588 supports INTx interrupts.

No functional change.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Link: https://lore.kernel.org/r/20250310111016.859445-14-cassel@kernel.org
drivers/pci/controller/dwc/pcie-dw-rockchip.c

index 93698abff4d9c7694822f33acb5f598240918ac5..4aa25bcf910608de08ccfc985fc10b53722acf1e 100644 (file)
@@ -272,6 +272,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3568 = {
        .linkup_notifier = true,
        .msi_capable = true,
        .msix_capable = true,
+       .intx_capable = false,
        .align = SZ_64K,
        .bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
        .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
@@ -292,6 +293,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3588 = {
        .linkup_notifier = true,
        .msi_capable = true,
        .msix_capable = true,
+       .intx_capable = false,
        .align = SZ_64K,
        .bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },
        .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },