]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cxl/hdm: Fix newline character in dev_err() messages
authorRobert Richter <rrichter@amd.com>
Fri, 9 Jan 2026 12:29:51 +0000 (13:29 +0100)
committerDave Jiang <dave.jiang@intel.com>
Thu, 22 Jan 2026 23:58:13 +0000 (16:58 -0700)
The newline character is not placed at the end of the string. This
causes unintended line wraps, broken log level and unterminated log
messages. Fix that for all messages.

Note that the messages are changed to use colons now instead of
parentheses, which is more common use.

Fixes: 24b18197184a ("cxl/hdm: Extend DVSEC range register emulation for region enumeration")
Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
Signed-off-by: Robert Richter <rrichter@amd.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Link: https://patch.msgid.link/20260109122952.639231-1-rrichter@amd.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/hdm.c

index 1c5d2022c87a99c1d8477efac33421e5195cadb5..6e516c69b2d2b3099610b890fcb1e3a3e81c1a11 100644 (file)
@@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
        rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
        if (rc) {
                dev_err(&port->dev,
-                       "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
+                       "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
                        port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
                return rc;
        }
@@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
        rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
        if (rc) {
                dev_err(&port->dev,
-                       "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
+                       "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
                        port->id, cxld->id, *dpa_base,
                        *dpa_base + dpa_size + skip - 1, rc);
                return rc;