]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: mmp: pxa1908-apbc: Fix NULL vs IS_ERR() check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 20 Nov 2024 17:18:38 +0000 (20:18 +0300)
committerStephen Boyd <sboyd@kernel.org>
Tue, 3 Dec 2024 20:02:25 +0000 (12:02 -0800)
The devm_kzalloc() function returns NULL on error, not error pointers.
Fix the check.

Fixes: 51ce55919273 ("clk: mmp: Add Marvell PXA1908 APBC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/d7078eb7-a7d6-4753-b453-8fce15245c34@stanley.mountain
Acked-by: Duje Mihanović <duje.mihanovic@skole.hr>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/mmp/clk-pxa1908-apbc.c

index b93d08466198569a975f580a1a3c27aae2b838c2..3fd7b5e644f3b6f6b24c09777923454c5ef238bd 100644 (file)
@@ -96,8 +96,8 @@ static int pxa1908_apbc_probe(struct platform_device *pdev)
        struct pxa1908_clk_unit *pxa_unit;
 
        pxa_unit = devm_kzalloc(&pdev->dev, sizeof(*pxa_unit), GFP_KERNEL);
-       if (IS_ERR(pxa_unit))
-               return PTR_ERR(pxa_unit);
+       if (!pxa_unit)
+               return -ENOMEM;
 
        pxa_unit->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(pxa_unit->base))