dmaengine: idxd: Expose ATS disable knob only when WQ ATS is supported

[ Upstream commit 62b41b656666d2d35890124df5ef0881fe6d6769 ]

WQ Advanced Translation Service (ATS) can be controlled only when
WQ ATS is supported. The sysfs ATS disable knob should be visible only
when the features is supported.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20230712174436.3435088-2-fenghua.yu@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Stable-dep-of: 0056a7f07b0a ("dmaengine: idxd: Allow ATS disable update only for configurable devices")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
index 36a30957ac9a3cebce756a7b78001e6445825a07..d16c16445c4f9b7ce47eda76be819b4f3e031b6e 100644 (file)
--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -1088,16 +1088,12 @@ static ssize_t wq_ats_disable_store(struct device *dev, struct device_attribute
                                    const char *buf, size_t count)
 {
        struct idxd_wq *wq = confdev_to_wq(dev);
-       struct idxd_device *idxd = wq->idxd;
        bool ats_dis;
        int rc;
 
        if (wq->state != IDXD_WQ_DISABLED)
                return -EPERM;
 
-       if (!idxd->hw.wq_cap.wq_ats_support)
-               return -EOPNOTSUPP;
-
        rc = kstrtobool(buf, &ats_dis);
        if (rc < 0)
                return rc;
@@ -1316,6 +1312,9 @@ static umode_t idxd_wq_attr_visible(struct kobject *kobj,
        if (idxd_wq_attr_invisible(prs_disable, wq_prs_support, attr, idxd))
                return 0;
 
+       if (idxd_wq_attr_invisible(ats_disable, wq_ats_support, attr, idxd))
+               return 0;
+
        return attr->mode;
 }