]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
perf dso: Add missed dso__put to dso__load_kcore
authorIan Rogers <irogers@google.com>
Tue, 24 Jun 2025 19:03:21 +0000 (12:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 10:08:53 +0000 (12:08 +0200)
[ Upstream commit 63a088e999de3f431f87d9a367933da894ddb613 ]

The kcore loading creates a set of list nodes that have reference
counted references to maps of the kcore. The list node freeing in the
success path wasn't releasing the maps, add the missing puts. It is
unclear why this leak was being missed by leak sanitizer.

Fixes: 83720209961f ("perf map: Move map list node into symbol")
Signed-off-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250624190326.2038704-2-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/perf/util/symbol.c

index ea24f21aafc3e352d180668e66ada1ecdf14713a..4f0bbebcb6d62db8bf80258405229410c6bd14ea 100644 (file)
@@ -1366,6 +1366,7 @@ static int dso__load_kcore(struct dso *dso, struct map *map,
                                goto out_err;
                        }
                }
+               map__zput(new_node->map);
                free(new_node);
        }