]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu/mmhub3.0.2: add bounds checking for cid
authorAlex Deucher <alexander.deucher@amd.com>
Wed, 4 Mar 2026 22:25:09 +0000 (17:25 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Mar 2026 16:18:58 +0000 (12:18 -0400)
The value should never exceed the array size as those
are the only values the hardware is expected to return,
but add checks anyway.

Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 1441f52c7f6ae6553664aa9e3e4562f6fc2fe8ea)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_2.c

index f0f182f033b9883c2d8866debc4a2165d871cbf6..e1f07f2a1852722942ea8795bced3bb2c1c1507e 100644 (file)
@@ -108,7 +108,8 @@ mmhub_v3_0_2_print_l2_protection_fault_status(struct amdgpu_device *adev,
                "MMVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
                status);
 
-       mmhub_cid = mmhub_client_ids_v3_0_2[cid][rw];
+       mmhub_cid = cid < ARRAY_SIZE(mmhub_client_ids_v3_0_2) ?
+               mmhub_client_ids_v3_0_2[cid][rw] : NULL;
        dev_err(adev->dev, "\t Faulty UTCL2 client ID: %s (0x%x)\n",
                mmhub_cid ? mmhub_cid : "unknown", cid);
        dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",