cpufreq: speedstep-lib: Use int type to store negative error codes

Change the return type of the speedstep_get_freqs() function from unsigned
int to int because it may return negative error codes.  For the same
reason, change the 'ret' variables to int type as well.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/20250902114545.651661-4-rongqianfeng@vivo.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
index 0b66df4ed513408f1b28e2ca5a5094c41a885717..f8b42e981635a81dc0460155df91a06827b6740e 100644 (file)
--- a/drivers/cpufreq/speedstep-lib.c
+++ b/drivers/cpufreq/speedstep-lib.c
@@ -378,16 +378,16 @@ EXPORT_SYMBOL_GPL(speedstep_detect_processor);
  *                     DETECT SPEEDSTEP SPEEDS                       *
  *********************************************************************/
 
-unsigned int speedstep_get_freqs(enum speedstep_processor processor,
-                                 unsigned int *low_speed,
-                                 unsigned int *high_speed,
-                                 unsigned int *transition_latency,
-                                 void (*set_state) (unsigned int state))
+int speedstep_get_freqs(enum speedstep_processor processor,
+                       unsigned int *low_speed,
+                       unsigned int *high_speed,
+                       unsigned int *transition_latency,
+                       void (*set_state)(unsigned int state))
 {
        unsigned int prev_speed;
-       unsigned int ret = 0;
        unsigned long flags;
        ktime_t tv1, tv2;
+       int ret = 0;
 
        if ((!processor) || (!low_speed) || (!high_speed) || (!set_state))
                return -EINVAL;

diff --git a/drivers/cpufreq/speedstep-lib.h b/drivers/cpufreq/speedstep-lib.h
index dc762ea786be96bdd0bfb11c05a8967903e71ff6..48329647d4c40d52b3c954a2581a2ac3fe4c4bee 100644 (file)
--- a/drivers/cpufreq/speedstep-lib.h
+++ b/drivers/cpufreq/speedstep-lib.h
@@ -41,8 +41,8 @@ extern unsigned int speedstep_get_frequency(enum speedstep_processor processor);
  * SPEEDSTEP_LOW; the second argument is zero so that no
  * cpufreq_notify_transition calls are initiated.
  */
-extern unsigned int speedstep_get_freqs(enum speedstep_processor processor,
-       unsigned int *low_speed,
-       unsigned int *high_speed,
-       unsigned int *transition_latency,
-       void (*set_state) (unsigned int state));
+extern int speedstep_get_freqs(enum speedstep_processor processor,
+                              unsigned int *low_speed,
+                              unsigned int *high_speed,
+                              unsigned int *transition_latency,
+                              void (*set_state)(unsigned int state));