]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: stm32: Don't warn about spurious interrupts
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 21 May 2024 10:52:42 +0000 (12:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:51 +0000 (13:39 +0200)
[ Upstream commit 95d7c452a26564ef0c427f2806761b857106d8c4 ]

The dev_warn to notify about a spurious interrupt was introduced with
the reasoning that these are unexpected. However spurious interrupts
tend to trigger continously and the error message on the serial console
prevents that the core's detection of spurious interrupts kicks in
(which disables the irq) and just floods the console.

Fixes: c64e7efe46b7 ("spi: stm32: make spurious and overrun interrupts visible")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://msgid.link/r/20240521105241.62400-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-stm32.c

index 191baa6e45c08ecd2528f43fc462eae58d32e2a8..e8d21c93ed7ef66bc5b21099dd531aa8cf423202 100644 (file)
@@ -884,7 +884,7 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id)
                mask |= STM32H7_SPI_SR_TXP | STM32H7_SPI_SR_RXP;
 
        if (!(sr & mask)) {
-               dev_warn(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n",
+               dev_vdbg(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n",
                         sr, ier);
                spin_unlock_irqrestore(&spi->lock, flags);
                return IRQ_NONE;