]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: fix enum conversion
authorJán Tomko <jtomko@redhat.com>
Tue, 1 Sep 2020 21:30:35 +0000 (23:30 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 1 Sep 2020 21:34:00 +0000 (23:34 +0200)
../src/conf/domain_conf.c:8144:78: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
        if ((def->writeFiltering = virTristateBoolTypeFromString(filtering)) < 0) {
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: 9d15647dcb96831c93ac8c1d67c47265b5ed9072
src/conf/domain_conf.c

index 7d177a55626437fffacf2754fbb859368858f3ef..72ac4f41914e981de591657f8c8352910d91823f 100644 (file)
@@ -8141,12 +8141,14 @@ virDomainHostdevSubsysPCIDefParseXML(xmlNodePtr node,
     xmlNodePtr cur;
 
     if ((filtering = virXMLPropString(node, "writeFiltering"))) {
-        if ((def->writeFiltering = virTristateBoolTypeFromString(filtering)) < 0) {
+        int val;
+        if ((val = virTristateBoolTypeFromString(filtering)) < 0) {
             virReportError(VIR_ERR_XML_ERROR,
                            _("unknown pci writeFiltering setting '%s'"),
                            filtering);
             return -1;
         }
+        def->writeFiltering = val;
     }
 
     cur = node->children;