drm/tegra: Fix a strange error handling path

The resource freed at the 'put_aux' label is "sor->aux->dev".
However, this resource is taken after devm_tegra_pmc_get(), so there is no
point to release it in this error handling path.

This is harmless because put_device() will be called with a NULL pointer,
but this is confusing.

So, fix the logic and return directly.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>

diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index a76095838133ee4e308ada6cbc4758792c167964..6479f852e16a443820e3c1e4a05bb09201bdd117 100644 (file)
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -3733,10 +3733,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
        sor->num_settings = sor->soc->num_settings;
 
        sor->pmc = devm_tegra_pmc_get(&pdev->dev);
-       if (IS_ERR(sor->pmc)) {
-               err = PTR_ERR(sor->pmc);
-               goto put_aux;
-       }
+       if (IS_ERR(sor->pmc))
+               return PTR_ERR(sor->pmc);
 
        np = of_parse_phandle(pdev->dev.of_node, "nvidia,dpaux", 0);
        if (np) {