]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: do WoW offloads only on primary link
authorBaochen Qiang <baochen.qiang@oss.qualcomm.com>
Mon, 3 Nov 2025 02:44:49 +0000 (10:44 +0800)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Fri, 16 Jan 2026 01:19:36 +0000 (17:19 -0800)
In case of multi-link connection, WCN7850 firmware crashes due to WoW
offloads enabled on both primary and secondary links.

Change to do it only on primary link to fix it.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00284-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1

Fixes: 32f7b19668bd ("wifi: ath12k: support MLO as well if single_chip_mlo_support flag is set")
Signed-off-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20251103-ath12-primary-link-wow-v1-1-3cf523dc09f0@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/wow.c

index f56ec44a1636139979ca072b4354462d97c9f1b6..bb08e1740582599fd4d396b9a5347a7727dd10c4 100644 (file)
@@ -135,6 +135,9 @@ static int ath12k_wow_cleanup(struct ath12k *ar)
        lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy);
 
        list_for_each_entry(arvif, &ar->arvifs, list) {
+               if (arvif != &arvif->ahvif->deflink)
+                       continue;
+
                ret = ath12k_wow_vif_cleanup(arvif);
                if (ret) {
                        ath12k_warn(ar->ab, "failed to clean wow wakeups on vdev %i: %d\n",
@@ -479,8 +482,12 @@ static int ath12k_wow_set_wakeups(struct ath12k *ar,
        lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy);
 
        list_for_each_entry(arvif, &ar->arvifs, list) {
+               if (arvif != &arvif->ahvif->deflink)
+                       continue;
+
                if (ath12k_wow_is_p2p_vdev(arvif->ahvif))
                        continue;
+
                ret = ath12k_wow_vif_set_wakeups(arvif, wowlan);
                if (ret) {
                        ath12k_warn(ar->ab, "failed to set wow wakeups on vdev %i: %d\n",
@@ -538,6 +545,9 @@ static int ath12k_wow_nlo_cleanup(struct ath12k *ar)
        lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy);
 
        list_for_each_entry(arvif, &ar->arvifs, list) {
+               if (arvif != &arvif->ahvif->deflink)
+                       continue;
+
                if (ath12k_wow_is_p2p_vdev(arvif->ahvif))
                        continue;
 
@@ -745,6 +755,9 @@ static int ath12k_wow_arp_ns_offload(struct ath12k *ar, bool enable)
        list_for_each_entry(arvif, &ar->arvifs, list) {
                ahvif = arvif->ahvif;
 
+               if (arvif != &ahvif->deflink)
+                       continue;
+
                if (ahvif->vdev_type != WMI_VDEV_TYPE_STA)
                        continue;
 
@@ -776,6 +789,9 @@ static int ath12k_gtk_rekey_offload(struct ath12k *ar, bool enable)
        lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy);
 
        list_for_each_entry(arvif, &ar->arvifs, list) {
+               if (arvif != &arvif->ahvif->deflink)
+                       continue;
+
                if (arvif->ahvif->vdev_type != WMI_VDEV_TYPE_STA ||
                    !arvif->is_up ||
                    !arvif->rekey_data.enable_offload)