]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: stp-xway: normalize return value of gpio_get
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Feb 2026 19:06:54 +0000 (11:06 -0800)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Mon, 23 Feb 2026 09:41:43 +0000 (10:41 +0100)
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by xway_stp_get() is normalized
to the [0, 1] range.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://patch.msgid.link/20260218190657.2974723-5-dmitry.torokhov@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpio-stp-xway.c

index 493c027afdd62bce268f3523bbf88223dddd0c41..78d6c78d4aab5cc206bbad4a5a00466acf22c593 100644 (file)
@@ -102,7 +102,7 @@ static int xway_stp_get(struct gpio_chip *gc, unsigned int gpio)
 {
        struct xway_stp *chip = gpiochip_get_data(gc);
 
-       return (xway_stp_r32(chip->virt, XWAY_STP_CPU0) & BIT(gpio));
+       return !!(xway_stp_r32(chip->virt, XWAY_STP_CPU0) & BIT(gpio));
 }
 
 /**