]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: platform: amd: add DRM_AMDGPU dependency
authorArnd Bergmann <arnd@arndb.de>
Fri, 15 May 2026 09:12:06 +0000 (11:12 +0200)
committerSakari Ailus <sakari.ailus@linux.intel.com>
Tue, 19 May 2026 11:49:25 +0000 (14:49 +0300)
With DRM_AMDGPU=m and DRM_AMD_ISP=y, it is possible to configura
VIDEO_AMD_ISP4_CAPTURE as built-in, but that fails to link:

aarch64-linux-ld: drivers/media/platform/amd/isp4/isp4_interface.o: in function `isp4if_gpu_mem_alloc.isra.0':
isp4_interface.c:(.text+0x1d0): undefined reference to `isp_kernel_buffer_alloc'
aarch64-linux-ld: drivers/media/platform/amd/isp4/isp4_interface.o: in function `isp4if_dealloc_fw_gpumem':
isp4_interface.c:(.text+0x26c): undefined reference to `isp_kernel_buffer_free'

Add a dependency on the tristate DRM_AMDGPU symbol in addition to
the boolean DRM_AMD_ISP=y, so this can only be built-in if
the ISP driver is also linked into the kernel itself.

Fixes: 9a54c285630c ("media: platform: amd: Introduce amd isp4 capture driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Bin Du <Bin.Du@amd.com>
Tested-by: Bin Du <Bin.Du@amd.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
drivers/media/platform/amd/isp4/Kconfig

index 55dd2dc453a208c30e28c656d24a9f7e9f328aef..9d1927af1cb8c1047e7c100cd5524c016f8f008a 100644 (file)
@@ -2,7 +2,9 @@
 
 config VIDEO_AMD_ISP4_CAPTURE
        tristate "AMD ISP4 and camera driver"
-       depends on DRM_AMD_ISP && VIDEO_DEV && HAS_DMA
+       depends on DRM_AMDGPU && DRM_AMD_ISP
+       depends on HAS_DMA
+       depends on VIDEO_DEV
        select VIDEOBUF2_CORE
        select VIDEOBUF2_MEMOPS
        select VIDEOBUF2_V4L2