]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: acme: acme_ctx_destroy() leaks auth->dns
authorWilliam Lallemand <wlallemand@irq6.net>
Sat, 21 Feb 2026 15:03:17 +0000 (16:03 +0100)
committerWilliam Lallemand <wlallemand@irq6.net>
Sat, 21 Feb 2026 15:10:29 +0000 (16:10 +0100)
365a696 ("MINOR: acme: emit a log for DNS-01 challenge response")
introduces the auth->dns member which is istdup(). But this member is
never free, instead auth->token was freed twice by mistake.

Must be backported to 3.2.

src/acme.c

index 28cdd076c3598251b42f84a36efbecb1656e45f7..437e6106828e9986edee2379d7bbc6be69df01ba 100644 (file)
@@ -878,7 +878,7 @@ static void acme_ctx_destroy(struct acme_ctx *ctx)
                istfree(&auth->auth);
                istfree(&auth->chall);
                istfree(&auth->token);
-               istfree(&auth->token);
+               istfree(&auth->dns);
                next = auth->next;
                free(auth);
                auth = next;