]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: cx231xx: Remove vidioc_s_ctrl callback
authorRicardo Ribalda <ribalda@chromium.org>
Sun, 23 Feb 2025 18:58:12 +0000 (18:58 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 5 Mar 2025 09:43:26 +0000 (10:43 +0100)
The driver has been converted to the control framework in the past:
commit 88b6ffedd901 ("[media] cx231xx-417: convert to the control
framework").

This function is never called, the core will only use the control
framework instead.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Tested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/cx231xx/cx231xx-417.c

index 06d61e52f018c521ad806f0290fa8a1c1396ead3..e585c8f6e4c53f8313827a36cc8723fd463ac852 100644 (file)
@@ -1538,20 +1538,6 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id id)
        return 0;
 }
 
-static int vidioc_s_ctrl(struct file *file, void *priv,
-                               struct v4l2_control *ctl)
-{
-       struct cx231xx *dev = video_drvdata(file);
-       struct v4l2_subdev *sd;
-
-       dprintk(3, "enter vidioc_s_ctrl()\n");
-       /* Update the A/V core */
-       v4l2_device_for_each_subdev(sd, &dev->v4l2_dev)
-               v4l2_s_ctrl(NULL, sd->ctrl_handler, ctl);
-       dprintk(3, "exit vidioc_s_ctrl()\n");
-       return 0;
-}
-
 static int vidioc_enum_fmt_vid_cap(struct file *file, void  *priv,
                                        struct v4l2_fmtdesc *f)
 {
@@ -1627,7 +1613,6 @@ static const struct v4l2_ioctl_ops mpeg_ioctl_ops = {
        .vidioc_enum_input       = cx231xx_enum_input,
        .vidioc_g_input          = cx231xx_g_input,
        .vidioc_s_input          = cx231xx_s_input,
-       .vidioc_s_ctrl           = vidioc_s_ctrl,
        .vidioc_g_pixelaspect    = vidioc_g_pixelaspect,
        .vidioc_g_selection      = vidioc_g_selection,
        .vidioc_querycap         = cx231xx_querycap,