]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-143874: Use self.message instead of raw print in `_exec_in_closure()` (#143875)
authorYongtao Huang <yongtaoh2022@gmail.com>
Tue, 20 Jan 2026 00:11:07 +0000 (08:11 +0800)
committerGitHub <noreply@github.com>
Tue, 20 Jan 2026 00:11:07 +0000 (16:11 -0800)
Lib/pdb.py
Lib/test/test_remote_pdb.py
Misc/NEWS.d/next/Library/2026-01-15-16-04-39.gh-issue-143874.1qQgvo.rst [new file with mode: 0644]

index 0464b288ef825ab72a487d2addb58a2a3a228a7b..b5d8f827827415ef38552dccf439ac51477f9ac0 100644 (file)
@@ -888,7 +888,7 @@ class Pdb(bdb.Bdb, cmd.Cmd):
         locals.update(pdb_eval["write_back"])
         eval_result = pdb_eval["result"]
         if eval_result is not None:
-            print(repr(eval_result))
+            self.message(repr(eval_result))
 
         return True
 
index ede99de981971a63fc127193529a3b5a055fa533..d26d63faa61ddb6cb3bb214c9633db520b2572bd 100644 (file)
@@ -1441,6 +1441,34 @@ class PdbConnectTestCase(unittest.TestCase):
             self.assertIn("Function returned: 42", stdout)
             self.assertEqual(process.returncode, 0)
 
+    def test_exec_in_closure_result_uses_pdb_stdout(self):
+        """
+        Expression results executed via _exec_in_closure() should be written
+        to the debugger output stream (pdb stdout), not to sys.stdout.
+        """
+        self._create_script()
+        process, client_file = self._connect_and_get_client_file()
+
+        with kill_on_error(process):
+            self._read_until_prompt(client_file)
+
+            self._send_command(client_file, "(lambda: 123)()")
+            messages = self._read_until_prompt(client_file)
+            result_msg = "".join(msg.get("message", "") for msg in messages)
+            self.assertIn("123", result_msg)
+
+            self._send_command(client_file, "sum(i for i in (1, 2, 3))")
+            messages = self._read_until_prompt(client_file)
+            result_msg = "".join(msg.get("message", "") for msg in messages)
+            self.assertIn("6", result_msg)
+
+            self._send_command(client_file, "c")
+            stdout, _ = process.communicate(timeout=SHORT_TIMEOUT)
+
+            self.assertNotIn("\n123\n", stdout)
+            self.assertNotIn("\n6\n", stdout)
+            self.assertEqual(process.returncode, 0)
+
 
 def _supports_remote_attaching():
     PROCESS_VM_READV_SUPPORTED = False
diff --git a/Misc/NEWS.d/next/Library/2026-01-15-16-04-39.gh-issue-143874.1qQgvo.rst b/Misc/NEWS.d/next/Library/2026-01-15-16-04-39.gh-issue-143874.1qQgvo.rst
new file mode 100644 (file)
index 0000000..a11cf71
--- /dev/null
@@ -0,0 +1 @@
+Fixed a bug in :mod:`pdb` where expression results were not sent back to remote client.