Don't leak FD's on empty values.

Patch from Stephan Jaeger

diff --git a/src/modules/rlm_linelog/rlm_linelog.c b/src/modules/rlm_linelog/rlm_linelog.c
index 0dc1486bb2622d7fca26531da7cac05e31505bbc..eecde9e44ae519041799fcaf718de97be4476b12 100755 (executable)
--- a/src/modules/rlm_linelog/rlm_linelog.c
+++ b/src/modules/rlm_linelog/rlm_linelog.c
@@ -195,21 +195,6 @@ static int do_linelog(void *instance, REQUEST *request)
        rlm_linelog_t *inst = (rlm_linelog_t*) instance;
        const char *value = inst->line;
 
-       /*
-        *      FIXME: Check length.
-        */
-       if (strcmp(inst->filename, "syslog") != 0) {
-               radius_xlat(buffer, sizeof(buffer), inst->filename, request,
-                           NULL);
-               
-               fd = open(buffer, O_WRONLY | O_APPEND | O_CREAT, 0600);
-               if (fd == -1) {
-                       radlog(L_ERR, "rlm_linelog: Failed to open %s: %s",
-                              buffer, strerror(errno));
-                       return RLM_MODULE_FAIL;
-               }
-       }
-
        if (inst->reference) {
                CONF_ITEM *ci;
                CONF_PAIR *cp;
@@ -248,6 +233,21 @@ static int do_linelog(void *instance, REQUEST *request)
        }
 
  do_log:
+       /*
+        *      FIXME: Check length.
+        */
+       if (strcmp(inst->filename, "syslog") != 0) {
+               radius_xlat(buffer, sizeof(buffer), inst->filename, request,
+                           NULL);
+               
+               fd = open(buffer, O_WRONLY | O_APPEND | O_CREAT, 0600);
+               if (fd == -1) {
+                       radlog(L_ERR, "rlm_linelog: Failed to open %s: %s",
+                              buffer, strerror(errno));
+                       return RLM_MODULE_FAIL;
+               }
+       }
+
        /*
         *      FIXME: Check length.
         */