]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
authorPeter Krempa <pkrempa@redhat.com>
Wed, 12 Mar 2025 15:58:07 +0000 (16:58 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 13 Mar 2025 14:38:16 +0000 (15:38 +0100)
All supported qemus have this and we already deleted alternate code.
Retire the feature flag.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
31 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml
tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml
tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_6.2.0_ppc64.xml
tests/qemucapabilitiesdata/caps_6.2.0_x86_64.xml
tests/qemucapabilitiesdata/caps_7.0.0_ppc64.xml
tests/qemucapabilitiesdata/caps_7.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml
tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml
tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml
tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml
tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml
tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml
tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml
tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml
tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml
tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml
tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml
tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml
tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml
tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml
tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml
tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml
tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml
tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml
tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml

index 82e7dc5ccc8e8b0b2fa17d55953033bbcdf3f117..615efbf021bbd254422f1033cde69049f6342ede 100644 (file)
@@ -565,7 +565,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
               /* 355 */
               "vhost-user-fs", /* QEMU_CAPS_DEVICE_VHOST_USER_FS */
               "query-named-block-nodes.flat", /* X_QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT */
-              "blockdev-snapshot.allow-write-only-overlay", /* QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY */
+              "blockdev-snapshot.allow-write-only-overlay", /* X_QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY */
               "blockdev-reopen", /* X_QEMU_CAPS_BLOCKDEV_REOPEN */
               "storage.werror", /* X_QEMU_CAPS_STORAGE_WERROR */
 
@@ -1573,7 +1573,6 @@ static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] = {
     { "blockdev-add/arg-type/+nbd/tls-hostname", QEMU_CAPS_BLOCKDEV_NBD_TLS_HOSTNAME },
     { "blockdev-add/arg-type/+qcow2/discard-no-unref", QEMU_CAPS_QCOW2_DISCARD_NO_UNREF },
     { "blockdev-add/arg-type/+virtio-blk-vhost-vdpa/$fdset", QEMU_CAPS_DEVICE_VIRTIO_BLK_VHOST_VDPA},
-    { "blockdev-snapshot/$allow-write-only-overlay", QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY },
     { "calc-dirty-rate/arg-type/mode", QEMU_CAPS_DIRTYRATE_MODE },
     { "chardev-add/arg-type/backend/+socket/data/reconnect", QEMU_CAPS_CHARDEV_RECONNECT },
     { "chardev-add/arg-type/backend/+socket/data/reconnect-ms", QEMU_CAPS_CHARDEV_RECONNECT_MILISECONDS },
index 620289572ea23a5b016bcd6f7ae549b18de88e49..4a865b13de16b6d9acdf16880dfefd21b2221cb6 100644 (file)
@@ -544,7 +544,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     /* 355 */
     QEMU_CAPS_DEVICE_VHOST_USER_FS, /* -device vhost-user-fs */
     X_QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT, /* query-named-block-nodes supports the 'flat' option */
-    QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY, /* blockdev-snapshot has the 'allow-write-only-overlay' feature */
+    X_QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY, /* blockdev-snapshot has the 'allow-write-only-overlay' feature */
     X_QEMU_CAPS_BLOCKDEV_REOPEN, /* 'blockdev-reopen' qmp command is supported */
     X_QEMU_CAPS_STORAGE_WERROR, /* virtio-blk,scsi-hd.werror */
 
index 3f34d4853c8e6635d81d54fb1981c059923c60cb..2dede610ef6673d932b173da8b119648d0fe00d7 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
index db1c6494537b8e2326b49a6140c062260c6dc49a..29f82b8a0ce4c1ad1038b712da69d7a5295e14ba 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 0c5336b9f44498012cae6b975b8d7f67b7e47d69..d26fd445717d8de4b1d8284a9baa2a37e7200c8b 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 2094c2e7612c9481abf7c94219aee8cfeec9db8d..1c05e529c44084daa9686920bd41728f65449cd0 100644 (file)
@@ -93,7 +93,6 @@
   <flag name='rng-builtin'/>
   <flag name='tpm-spapr'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='tcg'/>
index 0d74ef5490631802689267fd0b373f030414f65a..81882a3c4ec9ba35927a72f27eebbbbaf037e4c9 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index a19cdd7391322c48a74ad47f232368d6e50f3671..01930afc181d69b267c5d6b9507596ce91d35b51 100644 (file)
   <flag name='rng-builtin'/>
   <flag name='tpm-spapr'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 9fe235e7cb3a989537006205d3854b6e93fe6771..b82a49fb99b2e1c97e4e30267c76ff28a50ef04c 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 1cffb4d46c9bbbd4958d7102cf59a9d50d0f9988..d8c4e4ec1ec3d882dd89c5ba5a4bc561e6e6c647 100644 (file)
@@ -99,7 +99,6 @@
   <flag name='rng-builtin'/>
   <flag name='tpm-spapr'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 2fd7c14d89aa5b6b1ab988903946d1961df836c4..68c8d5f29774a4676679a0d78d4b3854fcf0a52d 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 775979c09efc859d3302ab3192f50ee69f24f671..ee49af7a57ae7485c0b29f6ac3c2690d9b924828 100644 (file)
@@ -92,7 +92,6 @@
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 8fdfa14e24c4b86db951a6486d5c9a20042b99b4..a42b4c30d9ae5380c021a77d3a6ece4fee56863f 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 6c78c3e6973c486f89db5dfbe9ea6543e7f49659..d4c8bcea18d990763b1f1b5ad01827353c5ff4ca 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index a0604e94b7d29df320dc8ba66c67a40ecd6de5c2..9e8eac73917e460b43da6dc863ff56791c321556 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index c667c62418cfa1c16b0a481269265bd3e7d4782b..439ccffcd55efc34a43857ee8c9d5fc012aa4dcc 100644 (file)
@@ -64,7 +64,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
index b1f6c765fc5217b282d935e0f181a7f750dc2eb3..d0d0b86c6ecf36b003e6d795a92a8f8f7fe1ec3f 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 7783054d8a98aa1b23ed6d99eb9ee5705a3439a5..310825c3fe85603305efb2db7f1f0beb6517928d 100644 (file)
@@ -98,7 +98,6 @@
   <flag name='rng-builtin'/>
   <flag name='cpu.kvm-no-adjvtime'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 4db71213c4243c63fc8cac5aeef3cee5372acd1f..73b7f470a8e70d689cb726b0a163b8799c3394a5 100644 (file)
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 2f710ae116e434bef380233855603deb6ff4cb1a..c924ef71ec591418a111cee2a3ef9be1ea8cd1af 100644 (file)
@@ -91,7 +91,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 67afe4be0b42b1918b4b41c0540d1c16c6ff521e..5049ce8f66a97ffb404ca9402b72b7e915452d36 100644 (file)
@@ -64,7 +64,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
index 847f1bb11b99d1e3df2c3919970a1c5d1790d018..be2502700168a3b82d96a0709f61ba45cdac3caf 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 15dc88b1666a179f208eb93d9de62fd7473b8d96..978f48ea3624e80581c163e6d89765e325ed6fa5 100644 (file)
@@ -30,7 +30,6 @@
   <flag name='drive-nvme'/>
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
index 12464925dcda7f71f35f72daf25474b85277948a..4867768fbd1ca2c81c9b2a0967340044adc0dd20 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index acba45001ca61660ad7ae0d6cc3ea51f90f87819..a86e2b5909f6845434c4abdac6c05e26b49e4565 100644 (file)
@@ -95,7 +95,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 30704ce4250f4cd827dea8ae9e9865f87dac889b..1dce3b34202d4b173ca6b7f01aa6c6e30f7ca075 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
index d9ac11c13f4738b53e0ba25da9ca42afde5bdc8f..5180ed9461eac396acda051057126559cb53c054 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index 2d1eb90d61644be869b1d738f3204ad32fa394ea..60e76ac09a5c11cbb2c0b225af796554e6c102eb 100644 (file)
@@ -75,7 +75,6 @@
   <flag name='drive-nvme'/>
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='tcg'/>
index b7d7446c6de30ed8a6cb7ea15c6a00cd50ca7291..38f8d0fe578102a58acfd5ed05e15a015fa8a472 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='smp-dies'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='aio.io_uring'/>
   <flag name='tcg'/>
index ba0141f71e04824c53b800c9b770b827581d8031..5cee701325f85e67c81b9c24ca5bc5c75cb93d9e 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>
index d97b77fa42c6e469dddc3c02f19b7a4c449444c8..424c2b9147cfc8ae661874769a5110eaafbf17d4 100644 (file)
   <flag name='i8042'/>
   <flag name='rng-builtin'/>
   <flag name='vhost-user-fs'/>
-  <flag name='blockdev-snapshot.allow-write-only-overlay'/>
   <flag name='fsdev.multidevs'/>
   <flag name='pcie-root-port.hotplug'/>
   <flag name='aio.io_uring'/>