color: Fix ip segfault when using --color switch

Commit d0e72011 ("ip: ipaddress.c: add support for json output")
introduced passing -1 as enum color_attr. This is not only wrong as no
color_attr has value -1, but also causes another segfault in color_fprintf()
on this setup as there is no item with index -1 in array of enum attr_colors[].
Using COLOR_CLEAR is valid option.

Reproduce with:
$ COLORFGBG='0;15' ip -c a

NOTE: COLORFGBG is environmental variable used for defining whether user
has light or dark background.
COLORFGBG="0;15" is used to ask for color set suitable for light background,
COLORFGBG="15;0" is used to ask for color set suitable for dark background.

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

diff --git a/include/json_print.h b/include/json_print.h
index b6ce1f9f95d17b28324c1afd9c89f0ff190012ed..596af35a3b0ee5abad4f02ea0e845fddc5c6ab30 100644 (file)
--- a/include/json_print.h
+++ b/include/json_print.h
@@ -53,7 +53,7 @@ void close_json_array(enum output_type type, const char *delim);
                                             const char *fmt,           \
                                             type value)                \
        {                                                               \
-               print_color_##type_name(t, -1, key, fmt, value);        \
+               print_color_##type_name(t, COLOR_CLEAR, key, fmt, value);       \
        }
 _PRINT_FUNC(int, int);
 _PRINT_FUNC(bool, bool);