]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
ftests: Add a test for creating a systemd scope
authorTom Hromatka <tom.hromatka@oracle.com>
Fri, 27 Jan 2023 20:46:27 +0000 (13:46 -0700)
committerTom Hromatka <tom.hromatka@oracle.com>
Fri, 27 Jan 2023 20:46:27 +0000 (13:46 -0700)
Add a test to exercise cgroup_create_scope2().

-----------------------------------------------------------------
Test Results:
        Run Date:                          Nov 18 16:12:16
        Passed:                                  1 test(s)
        Skipped:                                 0 test(s)
        Failed:                                  0 test(s)
-----------------------------------------------------------------
Timing Results:
        Test                                  Time (sec)
        ------------------------------------------------
        setup                                       0.00
        058-sudo-systemd_create_scope2.py           2.05
        teardown                                    0.00
        ------------------------------------------------
        Total Run Time                              2.05

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
tests/ftests/058-sudo-systemd_create_scope2.py [new file with mode: 0755]
tests/ftests/Makefile.am

diff --git a/tests/ftests/058-sudo-systemd_create_scope2.py b/tests/ftests/058-sudo-systemd_create_scope2.py
new file mode 100755 (executable)
index 0000000..247621b
--- /dev/null
@@ -0,0 +1,181 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: LGPL-2.1-only
+#
+# Create a systemd scope with an existing PID
+#
+# Copyright (c) 2023 Oracle and/or its affiliates.
+# Author: Tom Hromatka <tom.hromatka@oracle.com>
+#
+
+from cgroup import CgroupVersion as CgroupCliVersion
+from cgroup import Cgroup as CgroupCli
+from libcgroup import Cgroup, Version
+from run import Run, RunError
+from systemd import Systemd
+import ftests
+import consts
+import utils
+import stat
+import sys
+import os
+
+pid = None
+CGNAME = 'libcgtests.slice/058delegated.scope'
+
+# Which controller isn't all that important, but it is important that we
+# have a cgroup v2 controller
+CONTROLLER = 'cpu'
+
+# 0751
+DIR_MODE = stat.S_IRWXU | stat.S_IRGRP | stat.S_IXGRP | stat.S_IXOTH
+# 0644
+CTRL_MODE = stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRP | stat.S_IROTH
+# 0775
+TASK_MODE = stat.S_IRWXU | stat.S_IRWXG | stat.S_IXOTH
+
+TASKS_UID = 2468
+TASKS_GID = 3579
+CTRL_UID = 4680
+CTRL_GID = 5791
+
+
+def prereqs(config):
+    if config.args.container:
+        result = consts.TEST_SKIPPED
+        cause = 'This test cannot be run within a container'
+        return result, cause
+
+    if CgroupCliVersion.get_version(CONTROLLER) != CgroupCliVersion.CGROUP_V2:
+        result = consts.TEST_SKIPPED
+        cause = 'This test requires cgroup v2'
+        return result, cause
+
+    result = consts.TEST_PASSED
+    cause = None
+
+    return result, cause
+
+
+def setup(config):
+    pass
+
+
+def test(config):
+    global pid
+
+    result = consts.TEST_PASSED
+    cause = None
+
+    pid = int(config.process.create_process(config))
+
+    cg = Cgroup(CGNAME, Version.CGROUP_V2)
+
+    cg.add_controller(CONTROLLER)
+    cg.set_permissions(DIR_MODE, CTRL_MODE, TASK_MODE)
+    cg.set_uid_gid(TASKS_UID, TASKS_GID, CTRL_UID, CTRL_GID)
+
+    cg.create_scope2(ignore_ownership=False, pid=pid)
+
+    if not Systemd.is_delegated(config, os.path.basename(CGNAME)):
+        result = consts.TEST_FAILED
+        cause = 'Cgroup is not delegated'
+
+    if not CgroupCli.is_controller_enabled(config, CGNAME, CONTROLLER):
+        result = consts.TEST_FAILED
+        tmp_cause = 'Controller {} is not enabled in the parent cgroup'.format(CONTROLLER)
+        if not cause:
+            cause = tmp_cause
+        else:
+            cause = '{}\n{}'.format(cause, tmp_cause)
+
+    dir_path = os.path.join(CgroupCli.get_controller_mount_point(CONTROLLER), CGNAME)
+
+    dir_mode = utils.get_file_permissions(config, dir_path)
+    if int(dir_mode, 8) != DIR_MODE:
+        result = consts.TEST_FAILED
+        tmp_cause = 'Expected directory mode to be {} but it\'s {}'.format(
+                    format(DIR_MODE, '03o'), dir_mode)
+        if not cause:
+            cause = tmp_cause
+        else:
+            cause = '{}\n{}'.format(cause, tmp_cause)
+
+    ctrl_path = os.path.join(CgroupCli.get_controller_mount_point(CONTROLLER), CGNAME,
+                             'cgroup.procs')
+
+    ctrl_mode = utils.get_file_permissions(config, ctrl_path)
+    if int(ctrl_mode, 8) != CTRL_MODE:
+        result = consts.TEST_FAILED
+        tmp_cause = 'Expected cgroup.procs mode to be {} but it\'s {}'.format(
+                    format(CTRL_MODE, '03o'), ctrl_mode)
+        if not cause:
+            cause = tmp_cause
+        else:
+            cause = '{}\n{}'.format(cause, tmp_cause)
+
+    uid = utils.get_file_owner_uid(config, ctrl_path)
+    if uid != CTRL_UID:
+        result = consts.TEST_FAILED
+        tmp_cause = 'Expected cgroup.procs owner to be {} but it\'s {}'.format(CTRL_UID, uid)
+        if not cause:
+            cause = tmp_cause
+        else:
+            cause = '{}\n{}'.format(cause, tmp_cause)
+
+    gid = utils.get_file_owner_gid(config, ctrl_path)
+    if gid != CTRL_GID:
+        result = consts.TEST_FAILED
+        tmp_cause = 'Expected cgroup.procs group to be {} but it\'s {}'.format(CTRL_GID, gid)
+        if not cause:
+            cause = tmp_cause
+        else:
+            cause = '{}\n{}'.format(cause, tmp_cause)
+
+    return result, cause
+
+
+def teardown(config, result):
+    global pid
+
+    if pid is not None:
+        Run.run(['kill', '-9', str(pid)], shell_bool=True)
+
+    if result != consts.TEST_PASSED:
+        # Something went wrong.  Let's force the removal of the cgroups just to be safe.
+        # Note that this should remove the cgroup, but it won't remove it from systemd's
+        # internal caches, so the system may not return to its 'pristine' prior-to-this-test
+        # state
+        try:
+            CgroupCli.delete(config, None, CGNAME)
+        except RunError:
+            pass
+    else:
+        # There is no need to remove the scope.  systemd should automatically remove it
+        # once there are no processes inside of it
+        pass
+
+    return consts.TEST_PASSED, None
+
+
+def main(config):
+    [result, cause] = prereqs(config)
+    if result != consts.TEST_PASSED:
+        return [result, cause]
+
+    try:
+        result = consts.TEST_FAILED
+        setup(config)
+        [result, cause] = test(config)
+    finally:
+        teardown(config, result)
+
+    return [result, cause]
+
+
+if __name__ == '__main__':
+    config = ftests.parse_args()
+    # this test was invoked directly.  run only it
+    config.args.num = int(os.path.basename(__file__).split('-')[0])
+    sys.exit(ftests.main(config))
+
+# vim: set et ts=4 sw=4:
index 147af2675d6cac05309bf109cb3b9e87663093e8..7fd05f15f0f0d5edea2e6eb8b548565a36079914 100644 (file)
@@ -78,6 +78,7 @@ EXTRA_DIST_PYTHON_TESTS = \
                          055-sudo-set_uid_gid_v1.py \
                          056-sudo-set_permissions_v2.py \
                          057-sudo-set_permissions_v1.py \
+                         058-sudo-systemd_create_scope2.py \
                          098-cgdelete-non-existing-shared-mnt-cgroup-v1.py
 # Intentionally omit the stress test from the extra dist
 # 999-stress-cgroup_init.py