CVE-2019-14833: Use utf8 characters in the unacceptable password

This shows that the "check password script" handling has a bug.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
Signed-off-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/selftest/knownfail.d/unacceptable-passwords b/selftest/knownfail.d/unacceptable-passwords
new file mode 100644 (file)
index 0000000..75fa2fc
--- /dev/null
+++ b/selftest/knownfail.d/unacceptable-passwords
@@ -0,0 +1 @@
+^samba.tests.samba_tool.user_check_password_script.samba.tests.samba_tool.user_check_password_script.UserCheckPwdTestCase.test_checkpassword_unacceptable\(chgdcpass:local\)
\ No newline at end of file

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index b565d4664776c46afd964fa5076d7a2f46abe015..d7c22ce4e235546ce5dff4cd8a8caea4adac241d 100755 (executable)
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -1986,7 +1986,7 @@ sub provision_chgdcpass($$)
        my $extra_provision_options = undef;
        # This environment disallows the use of this password
        # (and also removes the default AD complexity checks)
-       my $unacceptable_password = "widk3Dsle32jxdBdskldsk55klASKQ";
+       my $unacceptable_password = "Paßßword-widk3Dsle32jxdBdskldsk55klASKQ";
        push (@{$extra_provision_options}, "--dns-backend=BIND9_DLZ");
        my $ret = $self->provision($prefix,
                                   "domain controller",