]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
FS-11903: Fix errors reported by PVS-Studio Static Code Analyzer for mod_local_stream
authorAndrey Volk <andywolk@gmail.com>
Fri, 12 Jul 2019 16:09:36 +0000 (20:09 +0400)
committerAndrey Volk <andywolk@gmail.com>
Mon, 15 Jul 2019 19:40:44 +0000 (23:40 +0400)
src/mod/formats/mod_local_stream/mod_local_stream.c

index d07bfb34f3550115c82213707ad11b544b9469d0..bb5fde7568c3a19098e99da41147b0aead9ab330 100644 (file)
@@ -1106,7 +1106,7 @@ static switch_status_t local_stream_file_read_video(switch_file_handle_t *handle
        }
 
        if (context->source->banner_txt) {
-               if ((!context->banner_timeout || context->banner_timeout >= now)) {
+               if (!context->banner_timeout || context->banner_timeout >= now) {
                        if (context->newres) {
                                switch_img_free(&context->banner_img);
                                context->newres = 0;
@@ -1276,12 +1276,12 @@ static void launch_thread(const char *name, const char *path, switch_xml_t direc
                        source->logo_pos = parse_img_position(val);
                } else if (!strcasecmp(var, "logo-opacity") && !zstr(val)) {
                        source->logo_opacity = atoi(val);
-                       if (source->logo_opacity < 0 && source->logo_opacity > 100) {
+                       if (source->logo_opacity < 0 || source->logo_opacity > 100) {
                                source->logo_opacity = 0;
                        }
                } else if (!strcasecmp(var, "text-opacity") && !zstr(val)) {
                        source->text_opacity = atoi(val);
-                       if (source->text_opacity < 0 && source->text_opacity > 100) {
+                       if (source->text_opacity < 0 || source->text_opacity > 100) {
                                source->text_opacity = 0;
                        }
                } else if (!strcasecmp(var, "volume")) {