]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/hns: Remove redundant 'phy_addr' in hns_roce_hem_list_find_mtt()
authorChengchang Tang <tangchengchang@huawei.com>
Thu, 22 Sep 2022 12:33:10 +0000 (20:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:31:54 +0000 (14:31 +0200)
[ Upstream commit 5f652387c5423a82453c5cb446a88834bf41a94b ]

This parameter has never been used. Remove it to simplify the function.

Link: https://lore.kernel.org/r/20220922123315.3732205-8-xuhaoyue1@hisilicon.com
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Haoyue Xu <xuhaoyue1@hisilicon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Stable-dep-of: 25655580136d ("RDMA/hns: Fix soft lockup during bt pages loop")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/hns/hns_roce_hem.c
drivers/infiniband/hw/hns/hns_roce_hem.h
drivers/infiniband/hw/hns/hns_roce_mr.c

index 99708a7bcda78517130320d723122b574b3c8794..57b84f5dc0f16250f643e1e6381569fa7059e67a 100644 (file)
@@ -1487,19 +1487,17 @@ void hns_roce_hem_list_init(struct hns_roce_hem_list *hem_list)
 
 void *hns_roce_hem_list_find_mtt(struct hns_roce_dev *hr_dev,
                                 struct hns_roce_hem_list *hem_list,
-                                int offset, int *mtt_cnt, u64 *phy_addr)
+                                int offset, int *mtt_cnt)
 {
        struct list_head *head = &hem_list->btm_bt;
        struct hns_roce_hem_item *hem, *temp_hem;
        void *cpu_base = NULL;
-       u64 phy_base = 0;
        int nr = 0;
 
        list_for_each_entry_safe(hem, temp_hem, head, sibling) {
                if (hem_list_page_is_in_range(hem, offset)) {
                        nr = offset - hem->start;
                        cpu_base = hem->addr + nr * BA_BYTE_LEN;
-                       phy_base = hem->dma_addr + nr * BA_BYTE_LEN;
                        nr = hem->end + 1 - offset;
                        break;
                }
@@ -1508,8 +1506,5 @@ void *hns_roce_hem_list_find_mtt(struct hns_roce_dev *hr_dev,
        if (mtt_cnt)
                *mtt_cnt = nr;
 
-       if (phy_addr)
-               *phy_addr = phy_base;
-
        return cpu_base;
 }
index fa84ce33076aca6a7b3d8d65c4a7b57f12630ee9..150922b22eaa6bc50aecbfb828d155a4d186b873 100644 (file)
@@ -132,7 +132,7 @@ void hns_roce_hem_list_release(struct hns_roce_dev *hr_dev,
                               struct hns_roce_hem_list *hem_list);
 void *hns_roce_hem_list_find_mtt(struct hns_roce_dev *hr_dev,
                                 struct hns_roce_hem_list *hem_list,
-                                int offset, int *mtt_cnt, u64 *phy_addr);
+                                int offset, int *mtt_cnt);
 
 static inline void hns_roce_hem_first(struct hns_roce_hem *hem,
                                      struct hns_roce_hem_iter *iter)
index 604dd38b5c8fd99e491e5d1b0e421dda19465b90..791a45802d6b28cdd8bdae5814f014f7bb337343 100644 (file)
@@ -614,7 +614,7 @@ static int mtr_map_region(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr,
        while (offset < end && npage < max_count) {
                count = 0;
                mtts = hns_roce_hem_list_find_mtt(hr_dev, &mtr->hem_list,
-                                                 offset, &count, NULL);
+                                                 offset, &count);
                if (!mtts)
                        return -ENOBUFS;
 
@@ -864,7 +864,7 @@ int hns_roce_mtr_find(struct hns_roce_dev *hr_dev, struct hns_roce_mtr *mtr,
                mtt_count = 0;
                mtts = hns_roce_hem_list_find_mtt(hr_dev, &mtr->hem_list,
                                                  start_index + total,
-                                                 &mtt_count, NULL);
+                                                 &mtt_count);
                if (!mtts || !mtt_count)
                        goto done;