Bug 2452: external_acl_type does not limit entries, leads to high memory usage

Set a nominal cap of 256*1024 entries per external_acl_type configured.
This can be adjusted as needed with the external_acl_type cache=N option.

diff --git a/src/external_acl.cc b/src/external_acl.cc
index 25988b13ca2b76fb0af0607e944fb6e91a3e0ff1..509850c0881cef323705b34a110de5288b718929 100644 (file)
--- a/src/external_acl.cc
+++ b/src/external_acl.cc
@@ -223,6 +223,8 @@ parse_externalAclHelper(external_acl ** list)
     a->ttl = DEFAULT_EXTERNAL_ACL_TTL;
     a->negative_ttl = -1;
     a->children = DEFAULT_EXTERNAL_ACL_CHILDREN;
+    a->cache_size = 256*1024;
+    a->quote = external_acl::QUOTE_METHOD_URL;
 
     token = strtok(NULL, w_space);
 
@@ -233,8 +235,6 @@ parse_externalAclHelper(external_acl ** list)
 
     token = strtok(NULL, w_space);
 
-    a->quote = external_acl::QUOTE_METHOD_URL;
-
     /* Parse options */
     while (token) {
         if (strncmp(token, "ttl=", 4) == 0) {