Bug 367649: Deleting an attachment should set isobsolete to 1

Patch by Olav Vitters <olav@bkor.dhs.org> r=LpSolit a=LpSolit

diff --git a/attachment.cgi b/attachment.cgi
index 7c3605bfd0a72268262644ee2402e36c1d084f8b..578adfac097934db01e0036edbf6b3ba72f5bf99 100755 (executable)
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -804,8 +804,10 @@ sub delete_attachment {
 
         $dbh->bz_lock_tables('attachments WRITE', 'attach_data WRITE', 'flags WRITE');
         $dbh->do('DELETE FROM attach_data WHERE id = ?', undef, $attach_id);
-        $dbh->do('UPDATE attachments SET mimetype = ?, ispatch = ?, isurl = ?
-                  WHERE attach_id = ?', undef, ('text/plain', 0, 0, $attach_id));
+        $dbh->do('UPDATE attachments SET mimetype = ?, ispatch = ?, isurl = ?,
+                         isobsolete = ?
+                  WHERE attach_id = ?', undef,
+                 ('text/plain', 0, 0, 1, $attach_id));
         $dbh->do('DELETE FROM flags WHERE attach_id = ?', undef, $attach_id);
         $dbh->bz_unlock_tables;