]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kunit: fix up const mis-match in many assert functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Dec 2025 12:32:47 +0000 (13:32 +0100)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 5 Jan 2026 22:32:03 +0000 (15:32 -0700)
In many kunit assert functions a const pointer is passed to
container_of() and out pops a non-const pointer, which really isn't the
correct thing to do at all.  Fix this up by correctly marking the
casted-to pointer as const to preserve the marking.

Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Rae Moar <raemoar63@gmail.com>
Cc: linux-kselftest@vger.kernel.org
Cc: kunit-dev@googlegroups.com
Link: https://lore.kernel.org/r/2025121746-result-staleness-5a68@gregkh
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/assert.c

index 867aa5c4bccf764757e190948b8e3a2439116786..4c751ad8506a5465e4596eca5b7fc787b0ceb493 100644 (file)
@@ -51,7 +51,7 @@ void kunit_unary_assert_format(const struct kunit_assert *assert,
                               const struct va_format *message,
                               struct string_stream *stream)
 {
-       struct kunit_unary_assert *unary_assert;
+       const struct kunit_unary_assert *unary_assert;
 
        unary_assert = container_of(assert, struct kunit_unary_assert, assert);
 
@@ -71,7 +71,7 @@ void kunit_ptr_not_err_assert_format(const struct kunit_assert *assert,
                                     const struct va_format *message,
                                     struct string_stream *stream)
 {
-       struct kunit_ptr_not_err_assert *ptr_assert;
+       const struct kunit_ptr_not_err_assert *ptr_assert;
 
        ptr_assert = container_of(assert, struct kunit_ptr_not_err_assert,
                                  assert);
@@ -117,7 +117,7 @@ void kunit_binary_assert_format(const struct kunit_assert *assert,
                                const struct va_format *message,
                                struct string_stream *stream)
 {
-       struct kunit_binary_assert *binary_assert;
+       const struct kunit_binary_assert *binary_assert;
 
        binary_assert = container_of(assert, struct kunit_binary_assert,
                                     assert);
@@ -145,7 +145,7 @@ void kunit_binary_ptr_assert_format(const struct kunit_assert *assert,
                                    const struct va_format *message,
                                    struct string_stream *stream)
 {
-       struct kunit_binary_ptr_assert *binary_assert;
+       const struct kunit_binary_ptr_assert *binary_assert;
 
        binary_assert = container_of(assert, struct kunit_binary_ptr_assert,
                                     assert);
@@ -185,7 +185,7 @@ void kunit_binary_str_assert_format(const struct kunit_assert *assert,
                                    const struct va_format *message,
                                    struct string_stream *stream)
 {
-       struct kunit_binary_str_assert *binary_assert;
+       const struct kunit_binary_str_assert *binary_assert;
 
        binary_assert = container_of(assert, struct kunit_binary_str_assert,
                                     assert);
@@ -237,7 +237,7 @@ void kunit_mem_assert_format(const struct kunit_assert *assert,
                             const struct va_format *message,
                             struct string_stream *stream)
 {
-       struct kunit_mem_assert *mem_assert;
+       const struct kunit_mem_assert *mem_assert;
 
        mem_assert = container_of(assert, struct kunit_mem_assert,
                                  assert);