]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
decode/vxlan/tests: don't memset new packet
authorVictor Julien <vjulien@oisf.net>
Tue, 25 Oct 2022 07:18:47 +0000 (09:18 +0200)
committerVictor Julien <vjulien@oisf.net>
Tue, 25 Oct 2022 08:39:10 +0000 (10:39 +0200)
src/decode-vxlan.c

index e73bc5642b397c5f543eee56e7a10a3c62d66feb..003154c6fb8e503c1f8a35b3f8f431e41311a9d1 100644 (file)
@@ -212,16 +212,13 @@ static int DecodeVXLANtest01 (void)
     FAIL_IF_NULL(p);
     ThreadVars tv;
     DecodeThreadVars dtv;
-
-    DecodeVXLANConfigPorts(VXLAN_DEFAULT_PORT_S);
-
     memset(&tv, 0, sizeof(ThreadVars));
-    memset(p, 0, SIZE_OF_PACKET);
     memset(&dtv, 0, sizeof(DecodeThreadVars));
 
+    DecodeVXLANConfigPorts(VXLAN_DEFAULT_PORT_S);
     FlowInitConfig(FLOW_QUIET);
-    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
 
+    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
     FAIL_IF(p->udph == NULL);
     FAIL_IF(tv.decode_pq.top == NULL);
 
@@ -231,7 +228,7 @@ static int DecodeVXLANtest01 (void)
 
     FlowShutdown();
     PacketFree(p);
-    PacketFree(tp);
+    PacketFreeOrRelease(tp);
     PASS;
 }
 
@@ -254,16 +251,13 @@ static int DecodeVXLANtest02 (void)
     FAIL_IF_NULL(p);
     ThreadVars tv;
     DecodeThreadVars dtv;
-
-    DecodeVXLANConfigPorts("1");
-
     memset(&tv, 0, sizeof(ThreadVars));
-    memset(p, 0, SIZE_OF_PACKET);
     memset(&dtv, 0, sizeof(DecodeThreadVars));
 
+    DecodeVXLANConfigPorts("1");
     FlowInitConfig(FLOW_QUIET);
-    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
 
+    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
     FAIL_IF(p->udph == NULL);
     FAIL_IF(tv.decode_pq.top != NULL);