]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
xhci: dbgtty: fix device unregister: fixup
authorŁukasz Bartosik <ukaszb@chromium.org>
Tue, 30 Dec 2025 18:32:37 +0000 (13:32 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:56 +0000 (10:14 +0100)
[ Upstream commit 74098cc06e753d3ffd8398b040a3a1dfb65260c0 ]

This fixup replaces tty_vhangup() call with call to
tty_port_tty_vhangup(). Both calls hangup tty device
synchronously however tty_port_tty_vhangup() increases
reference count during the hangup operation using
scoped_guard(tty_port_tty).

Cc: stable <stable@kernel.org>
Fixes: 1f73b8b56cf3 ("xhci: dbgtty: fix device unregister")
Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org>
Link: https://patch.msgid.link/20251127111644.3161386-1-ukaszb@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-dbgtty.c

index 349931a80cc84c5c5f06f40562d9ca4b7f3986c5..54b68ce8f2f54dffd102b7ace9ac2786aade6040 100644 (file)
@@ -522,7 +522,7 @@ static void xhci_dbc_tty_unregister_device(struct xhci_dbc *dbc)
         * Hang up the TTY. This wakes up any blocked
         * writers and causes subsequent writes to fail.
         */
-       tty_vhangup(port->port.tty);
+       tty_port_tty_vhangup(&port->port);
 
        tty_unregister_device(dbc_tty_driver, port->minor);
        xhci_dbc_tty_exit_port(port);