]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-daemon: Don't bother sending CTDB_SRVID_SET_NODE_FLAGS
authorMartin Schwenke <martin@meltin.net>
Thu, 8 Jul 2021 01:32:20 +0000 (11:32 +1000)
committerAmitay Isaacs <amitay@samba.org>
Thu, 9 Sep 2021 01:46:49 +0000 (01:46 +0000)
The code that handles this message is
ctdb_recoverd.c:monitor_handler().  Although it appears to do
something potentially useful, it only logs the flags changes.  All
changes made are to local structures - there are no actual
side-effects.

It used to trigger a takeover run when the DISABLED flag changed.
This was dropped back in commit
662f06de9fdce7b1bc1772a4fbe43de271564917.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14784
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/server/ctdb_monitor.c

index ad936925a30af19eddccf07c88e9f617fb7dde14..67b99c61e8ff13b8003d5bd9608e6d9bd4331dab 100644 (file)
@@ -499,10 +499,5 @@ int32_t ctdb_control_modflags(struct ctdb_context *ctdb, TDB_DATA indata)
                ctdb->recovery_mode = CTDB_RECOVERY_ACTIVE;
        }
 
-       /* tell the recovery daemon something has changed */
-       c->new_flags = node->flags;
-       ctdb_daemon_send_message(ctdb, ctdb->pnn,
-                                CTDB_SRVID_SET_NODE_FLAGS, indata);
-
        return 0;
 }